Skip to content

test semgrep#12225

Closed
0x00101010 wants to merge 1 commit intoethereum-optimism:developfrom
0x00101010:test/semgrep
Closed

test semgrep#12225
0x00101010 wants to merge 1 commit intoethereum-optimism:developfrom
0x00101010:test/semgrep

Conversation

@0x00101010
Copy link
Collaborator

test semgrep check issue

@codecov
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.97%. Comparing base (c2dc0ab) to head (932a677).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #12225   +/-   ##
========================================
  Coverage    74.97%   74.97%           
========================================
  Files           49       49           
  Lines         3665     3665           
========================================
  Hits          2748     2748           
  Misses         745      745           
  Partials       172      172           
Flag Coverage Δ
cannon-go-tests 74.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@smartcontracts
Copy link
Contributor

We recently made certain semgrep scan checks blocking -- seems like semgrep scan throws an error for external contributions which isn't ideal. Looking into it. May just revert.

@smartcontracts
Copy link
Contributor

#12227 reverting

@smartcontracts
Copy link
Contributor

Should be fixed now

@0x00101010 0x00101010 closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants